search

nhagen / react-intercom

A component to configure and enable Intercom in your react application
MIT License
237 stars 72 forks source link

Intercom API should take a method name and an object, not array. #86

Closed jonathan3692bf closed 4 years ago

jonathan3692bf commented 4 years ago

In src/intercomAPI.ts on branch 2.0, args should be an object, not an array.

Just change line 1 from:

export default function(method: string, ...args: Array<any>) {

to:

export default function(method: string, args: any) {
ChristianJacobsen commented 4 years ago

Not sure if this is what is being proposed fixed in #77? I think it is.

jonathan3692bf commented 4 years ago

True, though #77 lumps method and args together. Either way, we achieve the same goal, so I'll close this issue.