search

nhammond129 / ch.py

Python library for connecting to Chatango chat servers.
21 stars 20 forks source link

Adding the room.unbanlist to ch.py? #36

Closed AcePokeMaster closed 10 years ago

AcePokeMaster commented 10 years ago

I think adding a unbanlist to the ch.py would be good for moderation bots. This way the bot owner can find who was unbanning certain users just like the banlist does.

asl97 commented 10 years ago

https://github.com/Nullspeaker/ch.py/commit/ba5a1eb053bb3b74b59fda15f6662a4484bc9ca1

AcePokeMaster commented 10 years ago

Thank you @asl97 Btw just wondering if you forgot self._unbanlist = list() in the init of the class Room.

asl97 commented 10 years ago

@AcePokeMaster what are you talking about? i think you need to rest, you are tired, 734

AcePokeMaster commented 10 years ago

@asl97 Yeah I need sleep xD. One last thing, on the def _rcmd_unblocked(self, args) is missing this line:

    self._unbanlist.append((args[0], args[1], target, float(args[4]), user))
asl97 commented 10 years ago

you are annoying, why can't you just make a pull request?

AcePokeMaster commented 10 years ago

@asl97 I can't I'm on mobile.