search

nhartland / love-build

GitHub Action for building a LÖVE Project
https://github.com/marketplace/actions/love-build
MIT License
52 stars 9 forks source link

Built zip file is huge compared to building it manually #10

Closed RafaelWO closed 3 years ago

RafaelWO commented 3 years ago

Hey, I noticed that the resulting zip files are pretty huge, especially the ones for windows (e.g. see my release).

When I do it manually (see love2d wiki), my win64 zip is 87.6MB, but the artifact from the GitHub action is 659MB.

Any idea why this is the case?

P.S. I also noticed that the file size seems to increase - in fact, double - per built application:

image

80 2 ~= 166 166 2 ~= 329 329 * 2 ~= 659

RafaelWO commented 3 years ago

I dug a bit deeper and extracted the contents of the .exe (688MB big) within the *win64.zip and noticed that it contains a folder release (default output dir of the action) which contains the previously built files:

image

I.e. I found the cause of this issue, now one has to solve it (I'm already on it, but I don't have much spare time for this). I probably will drop a PR in ~1-2 weeks.

nhartland commented 3 years ago

Hey, apologies for the delayed replies, for some reason I wasn't watching this repo (fixed that!). Thanks for digging into this, and for the PR!