nhasan / FlightIntel

FlightIntel
GNU General Public License v3.0
17 stars 8 forks source link

Multiple code improvements - squid:S1118, common-java:DuplicatedBlocks, squid:S1848, squid:S1213, squid:S1197, squid:S1155, squid:S1488 #38

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1118 - Utility classes should not have public constructors. common-java:DuplicatedBlocks - Source files should not have any duplicated blocks. squid:S1848 - Objects should not be created to be dropped immediately without being used. squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order. squid:S1197 - Array designators "[]" should be on the type, not the variable. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S1488 - Local Variables should not be declared and then immediately returned or thrown. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1118 https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks https://dev.eclipse.org/sonar/rules/show/squid:S1848 https://dev.eclipse.org/sonar/rules/show/squid:S1213 https://dev.eclipse.org/sonar/rules/show/squid:S1197 https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S1488 Please let me know if you have any questions. George Kankava