nhejazi / biotmle

:package: :microscope: R/biotmle: Targeted Learning with Moderated Statistics for Biomarker Discovery
https://code.nimahejazi.org/biotmle/
Other
4 stars 2 forks source link

Switch heatmap to use superheat? #14

Closed nhejazi closed 7 years ago

nhejazi commented 7 years ago

Based on comments from the in-progress Bioconductor review, the NMF package seems to have been broken by recent updates in one of its dependencies (namely, grid). Considering that superheat will soon be on CRAN, it would be nice to use this (better) tool rather than the heatmap implementation (that was, admittedly) thrown together using NMF.

nhejazi commented 7 years ago

The superheat package is now on CRAN, making it a valid dependency by Bioconductor standards.

nhejazi commented 7 years ago

completed by 029ed55599722d3de8ca4d88300a56a93d96cdbc