nhejazi / biotmle

:package: :microscope: R/biotmle: Targeted Learning with Moderated Statistics for Biomarker Discovery
https://code.nimahejazi.org/biotmle/
Other
4 stars 2 forks source link

Fixes need for Matrix objects as output of assay #43

Closed nhejazi closed 6 years ago

nhejazi commented 6 years ago

This PR fixes the issue reported in #42, which caught an out-of-date use of t() on the object produced by SummarizedExperiment::assay(), which (at least as of Bioconductor 3.7) returns an object of class DataFrame. In biomarkertmle(), t() and other downstream functions (e.g., limma::normalizeBetweenArrays()) require a Matrix-like object, a status for which DataFrame apparently does not qualify. This has been fixed by adding an explicit call to as.matrix. The opportunity is also taken to amend documentation and make other less-intrusive packaging changes.

Changes

nhejazi commented 6 years ago

Merging despite failure on Bioc-devel.

nhejazi commented 6 years ago

Closes #42