nhejazi / biotmle

:package: :microscope: R/biotmle: Targeted Learning with Moderated Statistics for Biomarker Discovery
https://code.nimahejazi.org/biotmle/
Other
4 stars 2 forks source link

parallelization is a dumpster fire #76

Closed nhejazi closed 3 years ago

nhejazi commented 3 years ago

All of the logic in https://github.com/nhejazi/biotmle/blob/master/R/biotmle.R#L128-L152 should be re-written for simplification. Far too many options are set, and it's horribly unclear exactly what the parallelization scheme invoked is. In particular, there's not a good reason to support both of the Future and BiocParallel frameworks, and certainly no reason to invoke both. The constructor of biomarkertmle can be significantly simplified accordingly.

nhejazi commented 3 years ago

Resolved by #77