nhejazi / txshift

:package: :game_die: R/txshift: Efficient Estimation of the Causal Effects of Stochastic Interventions, with Corrections for Outcome-Dependent Sampling
https://codex.nimahejazi.org/txshift
Other
13 stars 4 forks source link

Fixes with normalizes ipcw weights #7

Closed benkeser closed 6 years ago

benkeser commented 6 years ago

I think these small fixes should do the trick. The fixes are as follows:

Based on a few by-hand runs on my computer, things appear to be giving sane answers with these fixes.

A couple other notes of things we may want to study in simulation that we might want to add:

nhejazi commented 6 years ago

Thanks much for these fixes @benkeser. Looks like, upon confirming everything works as desired, this should close #6.