nhibernate / fluent-nhibernate

Fluent NHibernate!
BSD 3-Clause "New" or "Revised" License
1.66k stars 686 forks source link

Remove Obsolete Deep Clone Function #640

Closed bethmaloney closed 7 months ago

bethmaloney commented 8 months ago

Remove the obsolete DeepClone function. This function was marked as obsolete back in 2020 and will no longer work with newer versions of .NET

Rational for removing DeepClone

The NetStandardSerialization class and ISurrogateProvider interface are also being removed. While they are public and haven't been marked as obsolete it seems unlikely that any consumer is relying on them. If they are then they can copy the code from CXuesong/BotBuilder.Standard.

This is my first PR so please let me know if anything needs to be changed.

hazzik commented 7 months ago

Thanks for the contribution. I cannot accept removal of a public interface even that it could be unused. Also, I'm not ready to release a major version yet.