search

nhibernate / fluent-nhibernate

Fluent NHibernate!
BSD 3-Clause "New" or "Revised" License
1.66k stars 686 forks source link

Add .NET 6/8 as target framework #679

Closed SymbioticKilla closed 3 months ago

SymbioticKilla commented 4 months ago

Hi,

is it possible to add supported .NET version?

Thanks!

hazzik commented 4 months ago

To do exactly what?

SymbioticKilla commented 4 months ago

Sorry, my bad! It was little bit complicated as I thought: image I need to reference extra newest iesi.collections Because nhibernate uses wildcards and 4.0.4 is minimal version, which will be automatically taken. This version ist .NET Standard 1.6.

SymbioticKilla commented 4 months ago

Ok, now is Antlr3.Runtime the problem: I've found your issue to update to Antlr4: https://github.com/nhibernate/nhibernate-core/issues/3155

oskarb commented 4 months ago

Ok, now is Antlr3.Runtime the problem:

What is it that is the actual problem?

SymbioticKilla commented 4 months ago

It produces huge package lock with .NET Standard in it and security tools find false positives.

hazzik commented 3 months ago

Unfortunately, adding .NET 6/8 build would not solve the problem mentioned. I would probably add the builds later, but not for this exact reason.