search

nhirschey / FSharp.Data.Fred

Wrapper for Federal Reserve Economic Data API https://nhirschey.github.io/FSharp.Data.Fred/
MIT License
2 stars 3 forks source link

Remove Json sample files from public API surface #7

Closed nhirschey closed 2 years ago

nhirschey commented 2 years ago

We should only expose things in the public API that are intended for external users. The Json samples are an internal implementation detail, so we should hide those in an internal module.

See EmbeddedResources.fs in FSharp.Data.Toolbox.Twitter. We should do the same thing here:

  1. create a new embedded resources file with a top-level module EmbeddedResources and put all the sample jsons there.
  2. Mark the module as internal.
  3. Add the file to the project above the JsonApi.fs and reference the json samples from there.
nhirschey commented 2 years ago

closed by https://github.com/nhirschey/FSharp.Data.Fred/pull/10