nhl / link-move

A model-driven dynamically-configurable framework to acquire data from external sources and save it to your database.
Apache License 2.0
35 stars 15 forks source link

The use of String.replace(..) in PathNormalizer causes massive Pattern creation #143

Closed andrus closed 6 years ago

andrus commented 6 years ago

Noticed that java.util.regex.Pattern is created millions of times during a simple LM run. Looks like the culprit is String.replace(..) in PathNormalizer. We must change that to a simple substring.

image
rzen commented 6 years ago

Wow. Nice catch and fix. Kudos.