Date conversion from string

nhl / link-move

A model-driven dynamically-configurable framework to acquire data from external sources and save it to your database.

Apache License 2.0

35 stars 15 forks source link

Closed MegaPapa closed 2 years ago

andrus commented 6 years ago

The PR looks good. May I ask for two things though:

Document the original problem in a GitHub issue, so that the context is clear to everybody.
In addition to unit tests add an integration test that demonstrates the original problem.

andrus commented 2 years ago

I just applied a fix, using parts of this PR, but without an attempt to merge the entire thing