nhl / link-move

A model-driven dynamically-configurable framework to acquire data from external sources and save it to your database.
Apache License 2.0
35 stars 15 forks source link

TargetMapper behavior has changed #176

Open aletr opened 4 years ago

aletr commented 4 years ago

TargetMapper behavior has changed. In the version without a DataFrame, com.nhl.link.move.runtime.task.createorupdate.TargetMapper#map throws an exception with the message like "Invalid key: " if duplicates were in the data source.

But in the version with a DataFrame, we can load duplicates in targed without any error messages.

In addition, even if we delete duplicates from the data source, duplicates will not be deleted from the target.

https://github.com/nhl/link-move/blob/124ebe01ae988f19b2830b250477db8633ad51c4/link-move/src/main/java/com/nhl/link/move/runtime/task/createorupdate/TargetMapper.java#L22-L34