rsregan
commented
2 years ago I've been unable to figure out what was going with snowcomp and soltab for years, as they would sometimes get in an infinite loop when compiled with gfortran. They would sometimes compile and sometimes not.
I didn't get an issue with the SNGL conversion with gfortran.
how did you figure out these issues? What compile options are you using?
R. Steve Regan U.S. Geological Survey 303-236-5008 (office) PO Box 25046, MS 413 Bldg 53 Denver Federal Center Lakewood, CO 80225-0046 success is rarely about finding the right solution to a problem — it’s more about finding the right problem to solve
From: jdhughes-usgs @.> Sent: Wednesday, February 2, 2022 12:35 PM To: nhm-usgs/prms @.> Cc: Regan, Robert S @.>; Mention @.> Subject: [EXTERNAL] Re: [nhm-usgs/prms] changes to build 5.3 with gfortran 11 (PR #21)
This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.
@rsreganhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frsregan&data=04%7C01%7Crsregan%40usgs.gov%7C90788a5eba964433996408d9e6832f18%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794273370910049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Z4SFskLxra2c2CP7Mn8omZTPHE3dXp4u3pRh%2Ftmtn6Y%3D&reserved=0 This is ready to go in my opinion. I would squash and merge to get rid of all of the commits to get GitHub actions up and running.
Changes include:
- Removing intrinsic SNGL() conversion for variables that are single precision (gfortran issue)
- Adding continuation & for lines in obs.f90 and soilzone.f90 exceeding 132 character (gfortran issue)
- Add allocated(Irr_type) check before setting to zero (gfortran issue)
- Modified snowcomp.f90 and soltab.f90 encoding to ansi to fix OneAPI build issue on Windows
- Add meson build files
- Add gfortran and ifort workflows to build PRMS on Linux, macOS, and Windows
You will need to enable actions on GitHub before merging this PR. You can look at my fork to see the latest gfortranhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjdhughes-usgs%2Fprms%2Factions%2Fruns%2F1785678875&data=04%7C01%7Crsregan%40usgs.gov%7C90788a5eba964433996408d9e6832f18%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794273370910049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FAYxzy%2Bh3%2FoWYgBrh8u%2BgG5HUYSjl%2FjfIWVT5X819a8%3D&reserved=0 and iforthttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjdhughes-usgs%2Fprms%2Factions%2Fruns%2F1785678876&data=04%7C01%7Crsregan%40usgs.gov%7C90788a5eba964433996408d9e6832f18%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794273370910049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=GWDCXSyJq0yRwv98dm31RZAqqYRQGSKD%2BjMpZz28QmA%3D&reserved=0 GitHub Actions workflow runs.
— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnhm-usgs%2Fprms%2Fpull%2F21%23issuecomment-1028288583&data=04%7C01%7Crsregan%40usgs.gov%7C90788a5eba964433996408d9e6832f18%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794273370910049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=dV43HbKjTiWKgE%2FVrcMY2ZfgZTvZzsTk6crVrleaZpY%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACLN2FNHAG3UF67G34E5FPDUZGBPJANCNFSM5NHJHLPA&data=04%7C01%7Crsregan%40usgs.gov%7C90788a5eba964433996408d9e6832f18%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794273370910049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=uXkWjlJn5P%2F7fvVh8fzNwat2ifz7d0lijcXT9FvNFig%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Crsregan%40usgs.gov%7C90788a5eba964433996408d9e6832f18%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794273370910049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=paL%2BNuC1PTO4svpTib%2BJV7tx5RhAf3TNaCn8%2FZMLShs%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Crsregan%40usgs.gov%7C90788a5eba964433996408d9e6832f18%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794273370910049%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Bi4mO6f7qlxePrlQkErf44yB4A4pGkZh%2FrHRHPIXOvc%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
jdhughes-usgs
@rsregan This is ready to go in my opinion. I would squash and merge to get rid of all of the commits to get GitHub actions up and running.
Changes include:
You will need to enable actions on GitHub before merging this PR. You can look at my fork to see the latest gfortran and ifort GitHub Actions workflow runs.