search

nhm-usgs / prms

Precipitation Runoff Modeling System
7 stars 9 forks source link

Increase precision of csv files #22

Open jdhughes-usgs opened 2 years ago

jdhughes-usgs commented 2 years ago

Not sure why the precision on output to csv files is limited to a float with 4 digits after the decimal in nhru_summary.f90.

9005 FORMAT ('(I4, 2(''-'',I2.2),',I0,'('','',F0.4))')

I would suggest modifying this to

9005 FORMAT ('(I4, 2(''-'',I2.2),',I0,'('','',G0))')

to get as much precision in the csv files as possible.

rsregan commented 2 years ago

We believe that the usability of output is probably to three decimal places. There user has the option to select ES10.3, F0.2, F0.3, F0.4, and F0.5 to write out values. Thus, user's can select significant digits and limit the size of output CSV files

R. Steve Regan U.S. Geological Survey 303-236-5008 (office) PO Box 25046, MS 413 Bldg 53 Denver Federal Center Lakewood, CO 80225-0046 success is rarely about finding the right solution to a problem — it’s more about finding the right problem to solve

From: jdhughes-usgs @.> Sent: Wednesday, February 2, 2022 12:46 PM To: nhm-usgs/prms @.> Cc: Subscribed @.***> Subject: [EXTERNAL] [nhm-usgs/prms] Increase precision of csv files (Issue #22)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

Not sure why the precision on output to csv files is limited to a float with 4 digits after the decimal in nhru_summary.f90.

9005 FORMAT ('(I4, 2(''-'',I2.2),',I0,'('','',F0.4))')

I would suggest modifying this to

9005 FORMAT ('(I4, 2(''-'',I2.2),',I0,'('','',G0))')

to get as much precision in the csv files as possible.

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnhm-usgs%2Fprms%2Fissues%2F22&data=04%7C01%7Crsregan%40usgs.gov%7Cee3002d0760745af3d6f08d9e684cebe%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794280355794741%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=G1y8LQfHXIXIrddtdt6j7%2B1Ek964xgjtWrRbQaj7cyg%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACLN2FLZVHDZDKNSGEJARRDUZGCZXANCNFSM5NM67VHQ&data=04%7C01%7Crsregan%40usgs.gov%7Cee3002d0760745af3d6f08d9e684cebe%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794280355794741%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Qsqrxs8xiZsgE8hPazkUA%2FMe13xUs2N1azk4DOtzZvM%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Crsregan%40usgs.gov%7Cee3002d0760745af3d6f08d9e684cebe%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794280355794741%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Bh0MgLgwmyTwySiDMJ7OvHXcLR02XvmYwV3TWX3HFAg%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Crsregan%40usgs.gov%7Cee3002d0760745af3d6f08d9e684cebe%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637794280355794741%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2B0VG0EecTb73D9xhTJb4%2Bh8Hb9LFSVzjZbGZPaiGElc%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

jdhughes-usgs commented 2 years ago

@rsregan I think the issue of what a user should present with respect to model results is different from the precision of model output. Precision less than model precision makes it difficult to use model output to perform external water budget calculations.