search

nhm-usgs / prms

Precipitation Runoff Modeling System
7 stars 9 forks source link

Unable to run NHM input with PRMS 5.3 #23

Open jdhughes-usgs opened 2 years ago

jdhughes-usgs commented 2 years ago

@rsregan @paknorton @pnorton-usgs NHM CONUS and DRB cutout datasets that run with version 5.2.1 do not run with the development version of 5.3.0. The error message is:

Due to error condition simulation halted

 Read error of Parameter File invalid parameter type: poi_gage_id
ERROR STOP 15

Error termination. Backtrace:
#0  0x10ac3f6ee
#1  0x10ac40395
#2  0x10ac417be
#3  0x10a4ba38b
#4  0x10a44a140
#5  0x10a42e3db
#6  0x10a6d3730
#7  0x10a6d3838

I am running prms version 5.3 compiled with gfortran version 11.2.0 on macOS.

Based on the source, it appears that poi_gage_id is an integer array instead of a character array in version 5.3.

rsregan commented 2 years ago

I didn't implement character parameters in the Fortran-only. Instead I changed the type of poi_gage_id, which violates downward compatibility, but I wasn't as concerned about that when making the original fortran-only version for MODSIM-GSFLOW or to put in the LIS system 6 years ago.

I have made some updates to prms 5.3 in my version, but I can't push them to your EC version.

R. Steve Regan U.S. Geological Survey 303-236-5008 (office) PO Box 25046, MS 413 Bldg 53 Denver Federal Center Lakewood, CO 80225-0046 success is rarely about finding the right solution to a problem — it’s more about finding the right problem to solve

From: jdhughes-usgs @.> Sent: Friday, February 11, 2022 4:10 PM To: nhm-usgs/prms @.> Cc: Regan, Robert S @.>; Mention @.> Subject: [EXTERNAL] [nhm-usgs/prms] Unable to run NHM input with PRMS 5.3 (Issue #23)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@rsreganhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frsregan&data=04%7C01%7Crsregan%40usgs.gov%7C471a0f9ae8454b1cb1fa08d9edb3b5c0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802178376931107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RD9GlnkYsYZkViaI6DDp9M0ka0x0iyYQeRcGi1T6Bpo%3D&reserved=0 @paknortonhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpaknorton&data=04%7C01%7Crsregan%40usgs.gov%7C471a0f9ae8454b1cb1fa08d9edb3b5c0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802178376931107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=TQslTiMF0Pz%2BsMXgJpBCnaiSWsWDWY35uwGzAEHYmDg%3D&reserved=0 @pnorton-usgshttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnorton-usgs&data=04%7C01%7Crsregan%40usgs.gov%7C471a0f9ae8454b1cb1fa08d9edb3b5c0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802178376931107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=6P7QhNkebNgn3ryb1id9u2pwOimhXzjPLKOnoFSIZxM%3D&reserved=0 NHM CONUS and DRB cutout datasets that run with version 5.2.1 do not run with the development version of 5.3.0. The error message is:

Due to error condition simulation halted

Read error of Parameter File invalid parameter type: poi_gage_id ERROR STOP 15

Error termination. Backtrace:

0 0x10ac3f6ee

1 0x10ac40395

2 0x10ac417be

3 0x10a4ba38b

4 0x10a44a140

5 0x10a42e3db

6 0x10a6d3730

7 0x10a6d3838

I am running prms version 5.3 compiled with gfortran version 11.2.0 on macOS.

Based on the source, it appears that poi_gage_id is an integer array instead of a character array in version 5.3.

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnhm-usgs%2Fprms%2Fissues%2F23&data=04%7C01%7Crsregan%40usgs.gov%7C471a0f9ae8454b1cb1fa08d9edb3b5c0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802178376931107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=a%2Buo%2FnE%2FPdC4T0xsvrdikUR%2FW%2F71tPlhctvkxrOUYTo%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACLN2FJ6JVC5LJTRJPKJI2TU2WJM7ANCNFSM5OFTDIHQ&data=04%7C01%7Crsregan%40usgs.gov%7C471a0f9ae8454b1cb1fa08d9edb3b5c0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802178376931107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=9x76dt5Hgx3lRpPV2u4lItR9sQ7ZwLrt7zHXL%2B9HnEo%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Crsregan%40usgs.gov%7C471a0f9ae8454b1cb1fa08d9edb3b5c0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802178376931107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=e7kSNRld5GKRgflKfxKuOmU1tqWZqoNp%2BujloLd9Low%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Crsregan%40usgs.gov%7C471a0f9ae8454b1cb1fa08d9edb3b5c0%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802178376931107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2FY4YmZx6ytF9j5BEiFRyRMyaGxFk85cCzw3aOt6UgHM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

jdhughes-usgs commented 2 years ago

@rsregan as I understood it from @paknorton @pnorton-usgs this is going to be an issue for NHM.

You could do a PR against my fork since the upsteam repo is on @langevin-usgs and I can't grant access. The prms 5.3 source is in the prms5.3.0 subdirectory.

rsregan commented 2 years ago

The NHM doesn't need the poi_gage_id parameter. It was only added for Lauren to use in a header of a csv file. Parker could change the type value easily or I can modify the code to ignore poi_gage_id or allow for character parameters.

My guess is that version 5.3 is just an intermediate step for the water use work and example for building the EC land surface modules.

If we must go down the use of the CONUS 404 output, I think low hanging fruit is to resurrect PRMS sub-daily modules. A big weakness in the sub-daily was the use of daily solar radiation and PET averaged across the time step. Hourly values from 404 can be input directly. The sub-daily routing and snow modules could be updated fairly easily. We have green-ampt infiltration, kinematic surface runoff and stream flow routing as well as method of characteristics and the snow-17 model running hourly. The sub-daily was last used in the DRB flood model that loosely coupled the HEC ResSim model with PRMS with adding the Lag-K method that the NWS river forecast centers used for streamflow routing.

Note, the prms 5.2.1 release is approved and available on the PRMS webpage

R. Steve Regan U.S. Geological Survey 303-236-5008 (office) PO Box 25046, MS 413 Bldg 53 Denver Federal Center Lakewood, CO 80225-0046 success is rarely about finding the right solution to a problem — it’s more about finding the right problem to solve

From: jdhughes-usgs @.> Sent: Friday, February 11, 2022 4:42 PM To: nhm-usgs/prms @.> Cc: Regan, Robert S @.>; Mention @.> Subject: [EXTERNAL] Re: [nhm-usgs/prms] Unable to run NHM input with PRMS 5.3 (Issue #23)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@rsreganhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frsregan&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Ie8IHZ1d87NyWEQ1k138oezJ4xO1qWy5TF6W9CtZuBc%3D&reserved=0 as I understood it from @paknortonhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpaknorton&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=OqabzsWGKc7rTpYOneOh9tkLHT9wbsRLW398qVoXiLo%3D&reserved=0 @pnorton-usgshttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnorton-usgs&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8ftoPl9dP56ow%2F6O5mn7x0J%2Fss9ehyfi6GP2Died4d4%3D&reserved=0 this is going to be an issue for NHM.

You could do a PR against my forkhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjdhughes-usgs%2FprmsNHMpy&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JeRDD18ld65C0hT1vgq7AW7LeDS3ddxVM5t1Pl76IEM%3D&reserved=0 since the upsteam repo is on @langevin-usgshttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flangevin-usgs&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Hba83tBvsZOkQ9A7RZ7TlfGitzXnJrmSDfmCqHtAfhk%3D&reserved=0 and I can't grant access. The prms 5.3 source is in the prms5.3.0 subdirectoryhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjdhughes-usgs%2FprmsNHMpy%2Ftree%2Fmain%2Fprms5.3.0&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=0x6WsY9P7tLkiSgYccBD0J0VNenjo76qYUP9kvXB6Vw%3D&reserved=0.

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnhm-usgs%2Fprms%2Fissues%2F23%23issuecomment-1036775167&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=pbDr92w3FhGErpd%2BsHUBYpLVLTWjP3YhyDmJv78fjts%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACLN2FMMTPUR5MTSBXEJ3DTU2WNFFANCNFSM5OFTDIHQ&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xeHSCnpVo1CV9Esu4k1XRSpWAcKhesO6c4akltqBZPA%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=kZ6Fd7%2B0wwuw41m9YZgc4F0b45i0sMaVa78S%2BUhzZoU%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Crsregan%40usgs.gov%7Cda5f308014fb423aef3e08d9edb834c7%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C637802197700804320%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nFmcMLCdoxsLnbkRmipvg3mLrcKNZUR8WWHu9i7AY0s%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

pnorton-usgs commented 2 years ago

@rsregan For the NHM this could be a problem with the HYDAT gages which actually have alpha characters in their IDs; I would expect the model to crash when it tries to read the alpha-numeric HYDAT IDs. It also makes it more difficult connecting the observed streamflow with the modeled.