nhn / toast-ui.vue-calendar

Toast UI Calendar for Vue
MIT License
195 stars 54 forks source link

When updating, private button dosen't work #52

Open abbb1399 opened 3 years ago

abbb1399 commented 3 years ago

Version

1.1.1,

Test Environment

Window,chrome

Current Behavior

// Write example code
 scheduleList: [
        {
          id: '1',
          calendarId: '0',
          title: '집청소',
          category: 'time',
          dueDateClass: '',
          start: today.toISOString(),
          end: getDate('hours', today, 3, '+').toISOString(),
          isPrivate: true
        },
       ....

image

When updating private events, private button(lock image) dosen't match isPriavte's value(true). It should be locked.

In your example(https://ui.toast.com/tui-calendar), private button works well. Is this error because of VueTUI calendar? tui-calendar latest version is 1.13.0 whereas toast-ui.vue-calendar's latest version is .1.1.1.

please let me know how to solve it.

Expected Behavior

jungeun-cho commented 3 years ago

This needs to be fixed.

It is supposed to set the raw: {class: 'private'} (or 'public') value of event object. but it is wrong.

 scheduleList: [
        {
          id: '1',
          calendarId: '0',
          title: '집청소',
          category: 'time',
          dueDateClass: '',
          start: today.toISOString(),
          end: getDate('hours', today, 3, '+').toISOString(),
          isPrivate: true,
          raw: { class: "private" }, // It works, but it's the wrong way!
        },

Since raw data is user-only data, it should not be used by referring internally to the calendar source code.

abbb1399 commented 3 years ago

Thanks a a lot. The problem solved. i hope the bug gets fixed in next patch.