nhn / toast-ui.vue-image-editor

Toast UI Image Editor for Vue
MIT License
187 stars 41 forks source link

fix: Read options when includeUi is false too #40

Closed fjwong closed 3 years ago

fjwong commented 3 years ago

Please check if the PR fulfills these requirements

Description

When the includeUi prop is set to false, ImageEditor ignores any other options passed to it and always uses editorDefaultOptions instead. A workaround is to set includeUi = true and set options = { includeUI: null, ...otheroptions } but I suppose this is not the intended behavior.

This PR fixes this and editorDefaultOptions is used by default if no options are passed to the component.

This library is great by the way, thank you for working on this.


Thank you for your contribution to TOAST UI product. πŸŽ‰ 😘 ✨

swtalk commented 3 years ago

Dooray! 메일 λ°œμ†‘ μ‹€νŒ¨ μ•ˆλ‚΄

메일 λ°œμ†‘ μ‹€νŒ¨ μ•ˆλ‚΄

@.***) λ‹˜κ»˜ 보낸 메일이 μ „μ†‘λ˜μ§€ λͺ»ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

      μ‹€νŒ¨ μ‚¬μœ λ₯Ό ν™•μΈν•΄λ³΄μ„Έμš”.

        * λ°›λŠ” μ‚¬λžŒΒ :Β 

@.***)

        * λ°œμ†‘ μ‹œκ°„Β :Β 

2021-07-28T11:03:46

        * 메일 제λͺ©Β :Β 

Re: [nhn/toast-ui.vue-image-editor] fix: Read options when includeUi is false too (#40)

            * μ‹€νŒ¨ μ‚¬μœ Β :Β 

λ°›λŠ” μ‚¬λžŒμ΄ νšŒμ›λ‹˜μ˜ 메일을 μˆ˜μ‹ μ°¨λ‹¨ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

      이 메일은 λ°œμ‹ μ „μš©μœΌλ‘œ νšŒμ‹ λ˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.
      더 κΆκΈˆν•˜μ‹  사항은
      ***@***.***
      으둜 λ¬Έμ˜ν•΄ μ£Όμ‹œκΈ° λ°”λžλ‹ˆλ‹€.

    Β© Dooray!.