nhn / tui.calendar

🍞📅A JavaScript calendar that has everything you need.
http://ui.toast.com/tui-calendar
MIT License
11.99k stars 1.29k forks source link

a time schedule that expands multiple days gets converted to all day schedule? #652

Open figofan opened 4 years ago

figofan commented 4 years ago

Summary

It seems like a time schedule that expands multiple days gets converted to all day schedule automatically, is there a way to prevent this behavior? I'd like the time schedule always to display in the time grid in week view, no matter how many days it expands. As in the screenshot, how to get time schedule a to display like time schedule b?

I've tried returning false from datetime.hasMultiDates, but it doesn't seem to make any difference. Can someone shed some light on how I can achieve this?

Screenshots

image

Version

1.12.13

Additional context

Add any other context about the problem here.

auto-comment[bot] commented 4 years ago

Thank you for raising an issue. We will try and get back to you as soon as possible.

Please make sure you have filled out issue respecting our form in English and given us as much context as possible. If not, the issue will be closed or not replied.

jungeun-cho commented 4 years ago

If the time range of the schedule is within 24 hours, it will be displayed on the time grid. The TOAST UI Calendar team will discuss it.

figofan commented 4 years ago

If the time range of the schedule is within 24 hours, it will be displayed on the time grid. The TOAST UI Calendar team will discuss it.

thank you!

I'll keep poking around the source code to see if I can get it working, I'd appreciate it if someone can point out which particular file to start with.

figofan commented 4 years ago

/**

I think I may have just found the solution to my problem, it's the function groupFunc in Base.js that treats time schedule as all day schedule when its time range exceeds 24 hrs. IMO, The logic hurts the flexibility to show time schedule in time grid instead of day grid, after all the property isAllDay has offered the option to treat time schedule as all day schedule.

Maybe I'm not seeing the whole picture here, I suggest you guys remove this logic. I'd be happy to submit a pull request for this if you guys agree.

pierre-H commented 1 year ago

@figofan any news ?

pierre-H commented 1 year ago

The solution proposed doesn't work ... :'(