search

nhn / tui.calendar

🍞📅A JavaScript calendar that has everything you need.
http://ui.toast.com/tui-calendar
MIT License
12.04k stars 1.3k forks source link

TypeScript and Angular 5 support #82

Closed kartikbb closed 5 years ago

kartikbb commented 6 years ago

Do you plan to introduce TypeScript and Angular 5 support anytime in near future?

dongsik-yoo commented 6 years ago

@vindiezel23 The wrappers of tui-calendar are maintained by community and users. So ngx-tui-calendar's users will be grateful for you if you send us PR. @Worthy7 I'm sorry but I can't maintain the ngx repo because NHNEnt offers the ngx repo by request of users.

worthy7 commented 6 years ago

@dongsik-yoo Well, someone needs to be in charge of pushing and fixing NPM packages.

dongsik-yoo commented 6 years ago

@brnrds Could please write about release process of npm package? @Worthy7 I agree. I ask @brnrds to provide the release process.

worthy7 commented 6 years ago

@brnrds poke

worthy7 commented 6 years ago

@dongsik-yoo Can you please give me NPM permission for now and I'll see what I can do

worthy7 commented 6 years ago

@dongsik-yoo https://www.npmjs.com/~worthy7

dongsik-yoo commented 6 years ago

Done. @Worthy7 has been added as a maintainer.

worthy7 commented 6 years ago

@dongsik-yoo How do you want this to work exactly? There are two ways: I make and add features and fix issues via pull requests, then you approve them and pull them into master, and then publish to NPM.

Or, I become a contributer on the repo, and I manage it all.

It makes no sense for me to have NPM permission but not GitHub permission. Let me know which one works for you - I don't mind either way, and I can tell you how to use NPM publish properly since I figured it out today.

dongsik-yoo commented 6 years ago

@Worthy7 Actually, I have to choose first option that you suggest. Because NHN Entertainment has the company's management policy of their repositories.

I also agree with you about different permission between NPM and Github. But it can't be done with this NHN repository.

How about using another independent repository again?

worthy7 commented 6 years ago

So who in NHN is going to check Pull requests and publish to NPM? If there is nobody then it's entirely pointless. I can teach you about how to do the NPM publishes. I wrote it here: https://github.com/Worthy7/tui.ngx-calendar/wiki/How-to-NPM-Publish-(for-devs)

Remove my permission from NPM then. I would rather keep this simple for myself. At some point I think that NHN should be contributing to this angular version anyway, so keeping the repo with you guys seems logical.

worthy7 commented 6 years ago

@dongsik-yoo Please merge in my pull request for ReadOnly, then the NPM changes one, and try to publish to NPM yourself then :-)

nicholasgcoles commented 6 years ago

@dongsik-yoo @Worthy7 , is there any update on the Angular 5/6/7 wrapper for this component?

worthy7 commented 6 years ago

@nicholasgcoles It's completely dead and it looks like it will stay that way.

dongsik-yoo commented 5 years ago

Typescript interface is here v1.9.1.