knightwing-network
commented
3 years ago I think the problem can be fixed by handling the returned end date differently in the _onClickSaveSchedule method when we are in this._isEditMode , ie modify form.end inside the if (this._isEditMode) block:
ScheduleCreationPopup.prototype._onClickSaveSchedule = function(target) {
var className = config.classname('popup-save');
var cssPrefix = config.cssPrefix;
var title;
var startDate;
var endDate;
var rangeDate;
var form;
var isAllDay;
if (!domutil.hasClass(target, className) && !domutil.closest(target, '.' + className)) {
return false;
}
title = domutil.get(cssPrefix + 'schedule-title');
startDate = new TZDate(this.rangePicker.getStartDate());
endDate = new TZDate(this.rangePicker.getEndDate());
if (!this._validateForm(title, startDate, endDate)) {
if (!title.value) {
title.focus();
}
return false;
}
isAllDay = !!domutil.get(cssPrefix + 'schedule-allday').checked;
rangeDate = this._getRangeDate(startDate, endDate, isAllDay);
form = {
calendarId: this._selectedCal ? this._selectedCal.id : null,
title: title,
location: domutil.get(cssPrefix + 'schedule-location'),
start: rangeDate.start,
end: rangeDate.end,
isAllDay: isAllDay,
state: domutil.get(cssPrefix + 'schedule-state').innerText,
isPrivate: !domutil.hasClass(domutil.get(cssPrefix + 'schedule-private'), config.classname('public'))
};
if (this._isEditMode) {
form.end = [modify end here];
this._onClickUpdateSchedule(form);
} else {
this._onClickCreateSchedule(form);
}
this.hide();
return true;
};
I cloned the repo, but I am getting an error when I run npm install
adhrinae
ron2015schmitt
Edited and corrected version
Describe the bug
Note that if you click Update without changing anything, the end date is correct.
To Reproduce
Steps to reproduce the behavior:
Month View, default popups
Click on a date and add an all-day event of 1 day in length: Event Created
Now click on the event so that the detail popup appears: Event details
Click Edit and in new pop up make an event of exactly two days (end = start + 1 day): Event Editing
Click UPDATE and result has the end date = start date Event Result
Expected behavior
It should create an event of two days.
Screenshots
See above
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.