Render empty table will crash the WW editor - Githubissues

nhn / tui.editor

🍞📝 Markdown WYSIWYG Editor. GFM Standard + Chart & UML Extensible.

http://ui.toast.com/tui-editor

MIT License

17.21k stars 1.76k forks source link

Render empty table will crash the WW editor #2744

Open gitpaladin opened 2 years ago

gitpaladin commented 2 years ago

Describe the bug

The return rows may be an empty array in https://github.com/nhn/tui.editor/blob/65c4983a2721729d36e1986d05b17ad30ab87e7c/apps/editor/src/wysiwyg/nodes/tableBody.ts#L23 So if you input <table></table> (which is a valid embedded HTML markdown) will cause Cannot read properties of undefined exception.

To Reproduce

see this sample https://codesandbox.io/s/toast-ui-editor-empty-table-bug-z0hxjk

Expected behavior

Render empty table or keep empty line.

Screenshots

Desktop (please complete the following information):

OS: [Win10 Pro]
Browser [Edge]
Version [3.2.0]

jwlee1108 commented 2 years ago

@gitpaladin Thank you for the issue and your contribution. I'll check it soon.