nhn / tui.editor

🍞📝 Markdown WYSIWYG Editor. GFM Standard + Chart & UML Extensible.
http://ui.toast.com/tui-editor
MIT License
16.91k stars 1.71k forks source link

a little css mistake about #3209

Open boa-yang opened 6 months ago

boa-yang commented 6 months ago

tui.editor use ProseMirror, but there is a little mistake of css:

overflow-X => overflow-x

some code here:

@media only screen and (max-width: 480px){.toastui-editor-popup{max-width:300px;margin-left:-150px}.toastui-editor-dropdown-toolbar{max-width:none}}.ProseMirror{font-family:Open Sans,Helvetica Neue,Helvetica,Arial,\\b098\\b214\\bc14\\b978\\ace0\\b515,Nanum Barun Gothic,\\b9d1\\c740\\ace0\\b515,Malgun Gothic,sans-serif;color:#222;font-size:13px;overflow-y:auto;overflow-X:hidden;height:calc(100% - 36px)}.ProseMirror
Spown commented 6 months ago

eyep, VUE is angry at node_modules\@toast-ui\editor\dist\toastui-editor-viewer.css:

warnings when minifying css:
▲ [WARNING] "overflow-X" is not a known CSS property [unsupported-css-property]

    <stdin>:1006:2:
      1006 │   overflow-X: hidden;
           │   ~~~~~~~~~~
           ╵   overflow-x

  Did you mean "overflow-x" instead?
boa-yang commented 6 months ago

eyep, VUE is angry at node_modules\@toast-ui\editor\dist\toastui-editor-viewer.css:

warnings when minifying css:
▲ [WARNING] "overflow-X" is not a known CSS property [unsupported-css-property]

    <stdin>:1006:2:
      1006 │   overflow-X: hidden;
           │   ~~~~~~~~~~
           ╵   overflow-x

  Did you mean "overflow-x" instead?

Thank you very much! Yes! the overflow-X is wrong, overflow-w is correct。 is the overflow-X special here ? or just a typing error ?

Spown commented 6 months ago

is the overflow-X special here ? or just a typing error ?

@boa-yang it's a lint warning during resource composition, meaning it's not causing any failure, just hinting that the css rule is wrong and won't be picked by a browser.

btw, there is a pull request with a fix, that was dropped for some reason. and the issue is year old by now #2932