nhn / tui.grid

🍞🔡 The Powerful Component to Display and Edit Data. Experience the Ultimate Data Transformer!
http://ui.toast.com/tui-grid/
MIT License
2.42k stars 394 forks source link

react-grid type duplication issue #1805

Open amoneynous opened 2 years ago

amoneynous commented 2 years ago

Describe the bug there are two contextMenu field in Grid Props type, one in GridOptions and the other in HTMLAttributes. So using grid context menu, both CreateMenuGroups & string types are required. I think code should be changed not using '&' AS-IS: type Props = Omit<GridOptions, 'el'> & EventMaps & HTMLAttributes & { oneTimeBindingProps?: Array<'data' | 'columns' | 'bodyHeight' | 'frozenColumnCount'>; };