Please check if the PR fulfills these requirements
[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change
Description
if the dataSource failed to response on sorting, it's errored on firing the errorResponse event.
eventBus.ts/createEventBus/trigger method uses setInstance method with the tui.Grid instance.
but the tui.Grid instance contains null at grid.store.data.filters.
and eventually it calls common.ts/assign with null value.
So I added null-check for it on this PR.
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
if the
dataSourcefailed to response on sorting, it's errored on firing theerrorResponseevent.eventBus.ts/createEventBus/triggermethod usessetInstancemethod with thetui.Gridinstance. but thetui.Gridinstance containsnullatgrid.store.data.filters. and eventually it callscommon.ts/assignwithnullvalue. So I added null-check for it on this PR.Thank you for your contribution to TOAST UI product. 🎉 😘 ✨