nhn / tui.grid

๐Ÿž๐Ÿ”ก The Powerful Component to Display and Edit Data. Experience the Ultimate Data Transformer!
http://ui.toast.com/tui-grid/
MIT License
2.4k stars 386 forks source link

fix: check/uncheck event emitted when multi check/uncheck via shift click #1965

Closed jajugoguma closed 10 months ago

jajugoguma commented 10 months ago

Please check if the PR fulfills these requirements

Description

Fixed an issue where multiple checks/unchecks using shift-click did not raise the check/unchecked event.

When an event is fired due to a single checkbox click, the event handler is passed the same arguments as before, but when an event is fired due to a multiple checkbox check, the event handler is passed rowKeys as an argument, which is an array containing all rowKeys instead of rowKey.


Thank you for your contribution to TOAST UI product. ๐ŸŽ‰ ๐Ÿ˜˜ โœจ

jajugoguma commented 10 months ago

์ด๊ฑด ํ…Œ์ŠคํŠธ๊ฐ€ ์ข€ ์–ด๋ ต๋‚˜์š”? ๋ฃจํ”„๊ฐ€ ๋“ค์–ด๊ฐ€์„œ ์กฐ๊ธˆ ๋งŽ์€ ๋ฐ์ดํ„ฐ ํ…Œ์ŠคํŠธ๊ฐ€ ํ•œ ๋ฒˆ ๋“ค์–ด๊ฐ€๋ฉด ์ข‹๊ฒ ๋‹ค ์‹ถ์–ด์š”.

ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€ ํ–ˆ๋Š”๋ฐ, Cypress 4.9.0์—์„œ๋Š” Shift-Click์„ ํ…Œ์ŠคํŠธ ํ•  ์ˆ˜๊ฐ€ ์—†๋„ค์š”... ๋‹ค๋ฅธ ๋ฐฉ๋ฒ•์ด ์žˆ์„๊นŒ ์ด๋ฆฌ ์ €๋ฆฌ ์ฐพ์•„๋ดค๋Š”๋ฐ ํ˜„์žฌ๋กœ์จ๋Š” ํ•ด๋‹น ๋ฒ„์ „์— ๋ฌธ์„œ ์ฐจ์ œ์— ์ ‘๊ทผ์ด ๋ถˆ๊ฐ€๋Šฅ ํ•œ ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค. ๊ทธ๋ž˜์„œ API ํ˜ธ์ถœ์„ ์ด์šฉํ•œ ๋™์ž‘์—๋งŒ ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ ํ–ˆ์Šต๋‹ˆ๋‹ค.

jwlee1108 commented 10 months ago

์ด๊ฑด ํ…Œ์ŠคํŠธ๊ฐ€ ์ข€ ์–ด๋ ต๋‚˜์š”? ๋ฃจํ”„๊ฐ€ ๋“ค์–ด๊ฐ€์„œ ์กฐ๊ธˆ ๋งŽ์€ ๋ฐ์ดํ„ฐ ํ…Œ์ŠคํŠธ๊ฐ€ ํ•œ ๋ฒˆ ๋“ค์–ด๊ฐ€๋ฉด ์ข‹๊ฒ ๋‹ค ์‹ถ์–ด์š”.

ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€ ํ–ˆ๋Š”๋ฐ, Cypress 4.9.0์—์„œ๋Š” Shift-Click์„ ํ…Œ์ŠคํŠธ ํ•  ์ˆ˜๊ฐ€ ์—†๋„ค์š”... ๋‹ค๋ฅธ ๋ฐฉ๋ฒ•์ด ์žˆ์„๊นŒ ์ด๋ฆฌ ์ €๋ฆฌ ์ฐพ์•„๋ดค๋Š”๋ฐ ํ˜„์žฌ๋กœ์จ๋Š” ํ•ด๋‹น ๋ฒ„์ „์— ๋ฌธ์„œ ์ฐจ์ œ์— ์ ‘๊ทผ์ด ๋ถˆ๊ฐ€๋Šฅ ํ•œ ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค. ๊ทธ๋ž˜์„œ API ํ˜ธ์ถœ์„ ์ด์šฉํ•œ ๋™์ž‘์—๋งŒ ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ ํ–ˆ์Šต๋‹ˆ๋‹ค.

5.0.0์—์„œ ์ถ”๊ฐ€๋๋„ค์š”. https://github.com/cypress-io/cypress/issues/486