fix: respect presetRatio on new cropzone

nhn / tui.image-editor

🍞🎨 Full-featured photo image editor using canvas. It is really easy, and it comes with great filters.

http://ui.toast.com/tui-image-editor

MIT License

6.98k stars 1.29k forks source link

fix: respect presetRatio on new cropzone #700

Closed omergy closed 2 years ago

omergy commented 2 years ago

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[ ] It's right issue type on title
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description

Problem (how it is now):

in crop mode
choose a preset ratio (eg. 16/9)
draw/make a new cropzone
the aspect ratio is not restricted to the chosen preset ratio (not like when resizing the cropzone by the corners)

This PR fixes that problem. When you now draw/make a new cropzone while having selected a preset ratio, that preset ratio is now respected.

lja1018 commented 2 years ago

@adzlocal Excuse me for not having answered your PR sooner. Thank you for your contribution. I'll review it later.

omergy commented 2 years ago

@lja1018 When do you think will you be able to review the PR? We would love to have this issue fixed upstream.

lja1018 commented 2 years ago

@adzlocal Sorry, I'm late. I will review it today.

lja1018 commented 2 years ago

@adzlocal Thank you again for your contribution and merge this PR.

lja1018 commented 2 years ago

I misclicked 'revert'.

omergy commented 2 years ago

@lja1018 Thank you for the review! Could you please update the npm package as well? https://www.npmjs.com/package/@toast-ui/vue-image-editor

lja1018 commented 2 years ago

@adzlocal Thank you. :) I'll let you know when I deploy the package.

omergy commented 2 years ago

@lja1018 Hey, the package still hasn't received an update – would you be able to do it till end of May? Thanks!

lja1018 commented 2 years ago

@adzlocal reflected in v3.15.3. Do you want to check?

omergy commented 2 years ago

@lja1018 We tried to update to v3.15.3 recently but this version disappeared from the npm package repository – could you please publish that version (again)? Thank you!

omergy commented 2 years ago

@lja1018 There's still no v3.15.3 available in the npm repository – as this fix should have been available since April could you please have another look at this issue?

lja1018 commented 2 years ago

@adzlocal I'm sorry for the late reply. I'll check.

omergy commented 2 years ago

@lja1018 There is a version difference between the base package and the vue wrapper:

toast-ui.image-editor was updated to v3.15.3
toast-ui.vue-image-editor was not updated

Could you take a look? Thanks.

lja1018 commented 1 year ago

@adzlocal Let me check. Thank you.