fix: fire TEXT_EDITING when addText with autofocus

nhn / tui.image-editor

🍞🎨 Full-featured photo image editor using canvas. It is really easy, and it comes with great filters.

http://ui.toast.com/tui-image-editor

MIT License

6.98k stars 1.29k forks source link

fix: fire TEXT_EDITING when addText with autofocus #711

Closed eomttt closed 2 years ago

eomttt commented 2 years ago

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description

issue: https://github.com/nhn/tui.image-editor/issues/709

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

eomttt commented 2 years ago

when text autofocus, events.TEXT_EDITING event not file. so in zoom.js -> _startHandModeWithSpaceBar method, this.isTextEditing variable not changed (set false default) so zoom.js -> this.startHandMode method call and focus out

lja1018 commented 2 years ago

@eomttt Thank you for your contribution. I'll merge them after testing.

stale[bot] commented 2 years ago

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

stale[bot] commented 2 years ago

This issue will be closed due to inactivity. Thanks for your contribution!

nhn / tui.image-editor

fix: fire TEXT_EDITING when addText with autofocus #711

Please check if the PR fulfills these requirements

Description

issue: https://github.com/nhn/tui.image-editor/issues/709