nhn / tui.image-editor

🍞🎨 Full-featured photo image editor using canvas. It is really easy, and it comes with great filters.
http://ui.toast.com/tui-image-editor
MIT License
6.83k stars 1.26k forks source link

missing localization keys + using 2 different naming conventions for the keys #885

Open YanivWein24 opened 10 months ago

YanivWein24 commented 10 months ago

I created an object for Hebrew localization and added it to "includeUI". When I started translating the image editor I noticed that there are 2 naming conventions for keys with more than 1 word.

one convention is PascalCase keys. for example:

{ 
  DeleteAll: "Lorem Ipsum",
  ZoomIn: "Lorem Ipsum",
  ZoomOut: "Lorem Ipsum"
}

And the other convention is kebab-case keys. for example:

{
  "Custom icon": "Lorem Ipsum",
  "Flip X":"Lorem Ipsum",
  "Flip Y": "Lorem Ipsum"
}

Using different naming conventions for the localization keys is not ideal and it makes it more difficult and time-consuming to translate the editor.

Furthermore, I didn't find the right keys for the following texts:

{
  "Remove white": "הסר לבן", 
  "Color filter": "פילטר צבע", 
  "Load mask image": "טען תמונה", 
}

I have also tried different combinations like "RemoveWhite", "Remove-White", "Remove-white" etc. Still couldn't find the right keys.