Optimize convert with constexpr pi in denominator

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.

http://nholthaus.github.io/units/

MIT License

962 stars 137 forks source link

Optimize convert with constexpr pi in denominator #132

Closed JohelEGP closed 6 years ago

JohelEGP commented 6 years ago

I missed this branch because I copy pasted the one above and missed adding - to PiRatio::num. Having only changed * for /, the wrong test results led me to believe that it was a problem with the expression being more inaccurate than before.

nholthaus commented 6 years ago

Conflicts from the int support branch. I'll pull this once those are worked out.

JohelEGP commented 6 years ago

This PR is subsumed by the accepted PR #126.