search

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.
http://nholthaus.github.io/units/
MIT License
952 stars 135 forks source link

Remove unused stuff #154

Closed JohelEGP closed 6 years ago

nholthaus commented 6 years ago

two questions:

JohelEGP commented 6 years ago

Can you remind me how/why we don't need has_same_scale anymore?

has_same_scale predates mixed-underlying type support. Using it constrains the nls member, and thus the underlying_type member, to being the same type.

do we have a trait to test whether a type T is a dimension or not? (I think it will be handy for concepts/user defined dimensions)

No. This one seems a leftover of the previous base_unit, which hard-coded all dimensions. It's unused in the current implementation.

Maybe I'm rushing it with these removals. Please, close it if you think so.

nholthaus commented 6 years ago

No, I'm just trying to get on the same page. Anything removed can always be put back, and my guess its if we did need them it would be in a newer form based on what you said.

On Fri, Jul 13, 2018, 8:16 PM Johel Ernesto Guerrero Peña < notifications@github.com> wrote:

Can you remind me how/why we don't need has_same_scale anymore?

has_same_scale predates mixed-underlying type support. Using it constrains the nls member, and thus the underlying_type member, to being the same type.

do we have a trait to test whether a type T is a dimension or not? (I think it will be handy for concepts/user defined dimensions)

No. This one seems a leftover of the previous base_unit, which hard-coded all dimensions. It's unused in the current implementation.

Maybe I'm rushing it with these removals. Please, close it if you think so.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nholthaus/units/pull/154#issuecomment-404983765, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ2HHz6e9wl2YJbJfdgydL0MMiX_fx3Nks5uGThugaJpZM4VG2Cz .

nholthaus commented 6 years ago

I've used github's web interface for conflict resolution, but it's not very good. Back to the command line!

On Fri, Jul 20, 2018 at 5:08 PM, Johel Ernesto Guerrero Peña < notifications@github.com> wrote:

@johelegp commented on this pull request.

In include/units.h https://github.com/nholthaus/units/pull/154#discussion_r204169678:

@@ -2703,7 +2703,6 @@ namespace units

  template<typename... T>
  inline constexpr bool has_decibel_scale_v = has_decibel_scale<T...>::value;
  • }

This } should be there to close the namespace. Was there a conflict with v3.x that prevented fast-forwarding? Otherwise, I think rebasing is the better option, as it marks conflicts like these to be solved.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/nholthaus/units/pull/154#pullrequestreview-139211664, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ2HH_oxTiqvF5l0SvPfXqJIZZi7ZkKKks5uIkbTgaJpZM4VG2Cz .