search

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.
http://nholthaus.github.io/units/
MIT License
961 stars 137 forks source link

Renaming the units to their natural spelling #159

Open JohelEGP opened 6 years ago

JohelEGP commented 6 years ago

For example, renaming meter_t to meters. This has probably been discussed in various places. I'll link to them as I find them.

To answer https://github.com/nholthaus/units/pull/150#issuecomment-405940556, I believe that, in the long run, renaming the units to their natural spelling is the right way to go. The _t suffix already has some uses that don't match the use in this library's units, like in the the standard type traits and the arguably more similar use in the types of <cstdint>. As the library becomes more popular, the _t suffix will become more of a baggage than the natural spelling the library can exploit with its CTAD capabilities and further possible improvements.

nholthaus commented 6 years ago

I agree with the logic. v3.0 is going to have a hefty upgrade burden on the users from 2.3, but that's the price of progress. We'll need an upgrade guide in the docs.

JohelEGP commented 6 years ago

What should we do about https://github.com/nholthaus/units/blob/5483589322daad285eedd4e2822058ba4e6640d8/include/units/pressure.h#L75 and similar cases which have the same singular and plural name?

JohelEGP commented 6 years ago

dimensionless_unit also needs a name revision.