Closed JohelEGP closed 5 years ago
Note that the CI fail above was due to Travis' spuriously errored jobs and doesn't have anything to do with the following commit.
@johelegp changes look good but probably better if you rebase this than me.
Rebased. Looks like df698c8 didn't work with Clang 5 as used in Travis.
yeah that looks like a clang bug to me, but meh, I'll just give it an initializer in another commit. I really want to get the renaming done so we cut down on our merge conflicts. It's sort of arbitrary but I have a desire to put out a beta release end of next week.
But then it wouldn't test what it's supposed to ;)
yeah I know, but I know in my heart that it works :)
I really want to get the renaming done so we cut down on our merge conflicts. It's sort of arbitrary but I have a desire to put out a beta release end of next week.
Looking forward to that.
conversion_factor
renaming.is_convertible_conversion_factor
tois_same_dimension
as per https://github.com/nholthaus/units/issues/185#issuecomment-423004260.Adds.store_linear_value_t
tag type, as per https://github.com/nholthaus/units/issues/185#issuecomment-423350563.unit
still forwards extra arguments to the scale, butunits
' scales now only know aboutstore_linear_value_t