search

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.
http://nholthaus.github.io/units/
MIT License
947 stars 135 forks source link

Fix data transfer rate unit's dimension #198

Closed JohelEGP closed 5 years ago

JohelEGP commented 5 years ago

I found it weird when I first read its declaration, as I'd expect it to be dimension_divide<data, time> and not make_dimension<data, std::ratio<-1>> like frequency is to time. Earlier, I finally tried to mix a data transfer unit with a time unit, and chaos ensued.

nholthaus commented 5 years ago

good catch... that made no sense on my part.