Failing common type of floating-point min and ms units

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.

http://nholthaus.github.io/units/

MIT License

947 stars 135 forks source link

Failing common type of floating-point min and ms units #215

Open JohelEGP opened 5 years ago

JohelEGP commented 5 years ago

Somehow std::common_type_t<minute_t<double>, millisecond_t<float>> is failing. You can use other floating-point types. But don't change the units' order! Or it will work...

JohelEGP commented 5 years ago

scoobbb Sorry. It was added in c57e5f4. This unsynchronized duplication bit me. You can get rid of it in #211, which removes the abbreviation-named conversion factors.

JohelEGP commented 3 years ago

This has been resolved.