nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.
http://nholthaus.github.io/units/
MIT License
938 stars 134 forks source link

Wrong conversion mil/mils to feet #241

Closed tom-vi closed 1 year ago

tom-vi commented 4 years ago

Version 2.3.1 gcc-linaro-7.1.1-2017.08-x86_64_arm-linux-gnueabihf

The conversion factor of mil/mils to feet seems to be wrong. In line 3351 UNIT_ADD(length, mil, mils, mil, unit<std::ratio<1000>, feet>) The ratio should be '1, 12000' UNIT_ADD(length, mil, mils, mil, unit<std::ratio<1, 12000>, feet>)