search

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.
http://nholthaus.github.io/units/
MIT License
938 stars 134 forks source link

revert: strong units #251

Closed JohelEGP closed 3 years ago

JohelEGP commented 3 years ago

resolves #219.

Refs: 1634c7864d782e9ef960e73a45a376a4b728ca30

This ICEs on GCC 10+ due to GCC 95486. So it may be incomplete.

JohelEGP commented 3 years ago

I'll specify the underlying type's as a template argument to make this C++17 again, like it was before the merge.

nholthaus commented 3 years ago

thank you for this. It's a bummer that CTAD didn't work out. It seems to be a hard language feature to specify and implement.

nholthaus commented 3 years ago

@johelegp the quality of your commit messages has been on my mind since yesterday... they're exquisite. Do you follow some system that I could read about?

JohelEGP commented 3 years ago

I'm happy to hear that. It's https://www.conventionalcommits.org/.