search

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.
http://nholthaus.github.io/units/
MIT License
934 stars 134 forks source link

Request for branch and pull request permissions #300

Open swarcojiz opened 1 year ago

swarcojiz commented 1 year ago

Hi Nic,

since a few weeks I am using your library in our production code and I really like your library.

But I have seen some minor topics on this library. But before I am opening an issue for each topic and also to support you a little bit, I would like to open pull requests directly if this is ok for you.

If you don't want to have pull requests from external guys, then this is also totally fine for me 😄

nholthaus commented 1 year ago

External PRs for bug fixes are always welcome. New features are welcome to buy is better to stay that discussion in an issue.

On Thu, Nov 24, 2022, 6:56 AM Jan Izyk @.***> wrote:

Hi Nic,

since a few weeks I am using your library in our production code and I really like your library.

But I have seen some minor topics on this library. But before I am opening an issue for each topic and also to support you a little bit, I would like to open pull requests directly if this is ok for you.

If you don't want to have pull requests from external guys, then this is also totally fine for me 😄

— Reply to this email directly, view it on GitHub https://github.com/nholthaus/units/issues/300, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOYOH4M3UZX76PCUDOIXBLWJ5JYVANCNFSM6AAAAAASKKGFKQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

swarcojiz commented 1 year ago

Ok nice. I agree, that new features shall be discussed in an issue.

swarcojiz commented 1 year ago

Can you then change the branch permissions, that also other people can create branches? The bugs which I have seen are:

  1. The version number in master is still 2.3.2 and not 2.3.3
  2. In master branch the unit test to_string_locale fails in line 1420
nholthaus commented 1 year ago

good catch with the version number.

For the string_locale test to succeed, you need to have a German locale installed (it's not by default). I'd make sure that's in place and see if the test still fails.

JohelEGP commented 1 year ago

Yeah, that's https://github.com/nholthaus/units/issues/127.