search

nholthaus / units

a compile-time, header-only, dimensional analysis and unit conversion library built on c++14 with no dependencies.
http://nholthaus.github.io/units/
MIT License
962 stars 137 forks source link

Remove an unused parameter warning for clang #99

Closed maikel closed 6 years ago

maikel commented 6 years ago

When using clang with -Wall and -Wextra it complains because of unused parameters. Since the parameter do not get used with any configuration I removed the parameter names instead of using the attribute [[maybe_unused]].

nholthaus commented 6 years ago

hmm, pretty sure that should return lhs + rhs, not 0

maikel commented 6 years ago

IIUC if this overload gets instantiated it will definitively raise the static_assert. Therefore just return 0;.