Add dark theme - Githubissues

nhooyr / blog

My personal blog

https://nhooyr.io

MIT License

4 stars 2 forks source link

Add dark theme #30

Closed nhooyr closed 4 years ago

nhooyr commented 4 years ago

Closes #28

github-actions[bot] commented 4 years ago

Pull Request Test Coverage Report for Build 40f2e51251857d0881123590f1e4f54183e7fde4-PR-30

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.478%

Totals
Change from base Build 2a4726aaf4d4b05035832d50b4359c90b0cd43e6:	0.0%
Covered Lines:	34
Relevant Lines:	34

💛 - Coveralls

coadler commented 4 years ago

Still seems broken unless you haven't deployed

nhooyr commented 4 years ago

@coadler get a real dark theme going. I'm using the css:

@media (prefers-color-scheme: dark)

to switch it which works on browsers that support setting dark/light preference like Chrome on iOS/Safari on Mac/Safari on iOS, I'm sure there's a switch on chrome on linux too.

nhooyr commented 4 years ago

E.g. try on ur phone with dark theme enabled.

coadler commented 4 years ago

I'm using chrome://flags/#enable-force-dark

nhooyr commented 4 years ago

That's not setting a preference if the site supports it, that's forcing it. It's overriding all my CSS and fucking it up, I can't do anything afaik.

coadler commented 4 years ago

:cry: