search

nhorman / rng-tools

The rng-tools official repository (formerly part of the gkernel project on sourceforge)
GNU General Public License v2.0
156 stars 62 forks source link

rngd_jitter: decreased a thread on some of ARM platform #186

Closed chenxy1988 closed 1 year ago

chenxy1988 commented 1 year ago

Dear maintainer,

Due to ARM cpu pipeline less than x86 or other arch, it would use more effort to generate data from jitter. this might block other process during system bootup, so decreased a thread to reserve resource for other process when system bootup. Just tested on armv7 and aarch64 platform only, so add armv7 & aarch64 macro only.

Thanks!

nhorman commented 1 year ago

why would you do this? Given that: 1) Theres no evidence that reducing thread count by 1 unilaterally improves performance on all arm cpus 2) Theres already an administrative command line switch that allows you to specify the number of threads that are started for the jitter source

I don't see why we need arch specific controls as well. It just makes things more complicated