search

nhorvath / Pyrebase4

A simple python wrapper for the Firebase API. ⛺
254 stars 63 forks source link

make threaded stream optional #14

Closed steliosrammos closed 4 years ago

steliosrammos commented 4 years ago

Making the stream threaded by default removes some flexibility for users that want to pass different arguments to the Thread (such as passing it a name), or that want to override the Thread (eg: for exception handling).

Making the threading optional is also cleaner than changing the source code to let users pass all Thread arguments.

This change makes the stream threaded by default to maintain the current default behaviour.

nhorvath commented 4 years ago

Thanks for the PR!

steliosrammos commented 4 years ago

Thanks for merging 👊

On Mon, 24 Aug 2020 at 20:08, Nick Horvath notifications@github.com wrote:

Thanks for the PR!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nhorvath/Pyrebase4/pull/14#issuecomment-679282626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2S7RPMAV3UNIBGY5JZMU3SCKUCNANCNFSM4QJWFN5Q .