nhosoya / omniauth-apple

OmniAuth strategy for Sign In with Apple
MIT License
260 stars 99 forks source link

Remove script_name from callback_url #72

Closed jeffsawatzky closed 1 year ago

jeffsawatzky commented 3 years ago

We recently upgraded rails and omniauth, and I'm not sure which one broke things, but all of a sudden this gem started to generate the wrong callback_url, and it adds the script_name multiple times now.

Looking at the base strategy, as well as some other popular strategies (github, google) I noticed that they do not include the script_name in their callback_url method. Base GitHub Google

nov commented 1 year ago

https://github.com/nhosoya/omniauth-apple/pull/88