search

nhosoya / omniauth-apple

OmniAuth strategy for Sign In with Apple
MIT License
260 stars 99 forks source link

rspec failure - callback_path null pointer #74

Closed btalbot closed 1 year ago

btalbot commented 3 years ago

One spec test for #callback_path is failing due to the rack env not being available.

The setup is done in the OAuth2#authorize_params method for some reason which must be called after all options under test are configured but before any methods that expect the setup to be complete: so not easy to find a single location to always call it.

This fixes the issue when testing the callback_path configuration. I don't know why this worked in the past but something probably changed in an upstream library to expose this issue recently.

btalbot commented 3 years ago

Note that this bug only affects spec tests as real use has the environment properly configured when called via Rack