search

nhosoya / omniauth-apple

OmniAuth strategy for Sign In with Apple
MIT License
260 stars 99 forks source link

Oauth2 version 2.0.0 breaks omniauth-apple #85

Closed dli1022 closed 1 year ago

dli1022 commented 2 years ago

Specifically this line in the Oauth2 2.0.0 release changelog breaks omniauth-apple gem:

"https://github.com/oauth-xx/oauth2/pull/312 - BREAKING: Set :basic_auth as default for :auth_scheme instead of :request_body. This was default behavior before 1.3.0. (@tetsuya, @wy193777)

Apple get token call needs the "client_id" and "client_secret" in the body, which will only be sent if Oauth2 "auth_scheme" type is ":request_body"

Please provide a fix or advice how we can set the :auth_scheme to :request_body through omniquth options. Thanks

thenathanjones commented 1 year ago

@nhosoya how can we help get some progress on updating to support OAuth 2.0.0? Many of us using this are also using Facebook and Google strategies which work with the new version and it feels risky to not be able to update.

smenor commented 1 year ago

Just tagging on a « me-too » to this @nhosoya

smenor commented 1 year ago

Thank you !

thenathanjones commented 1 year ago

Indeed, thank you!

El mar, 27 sept 2022 17:53, Scott Menor @.***> escribió:

Thank you !

— Reply to this email directly, view it on GitHub https://github.com/nhosoya/omniauth-apple/issues/85#issuecomment-1259263949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYXC4QXWJNEKWH2ZSHLBTWAK7YVANCNFSM56SZLW5Q . You are receiving this because you commented.Message ID: @.***>