nhost / cli

Nhost CLI
https://docs.nhost.io/development/cli/overview
MIT License
77 stars 28 forks source link

fix: don't remove `v` from the version #866

Closed dbarrosop closed 7 months ago

dbarrosop commented 7 months ago

Fixes #859

mainstreetmark commented 7 months ago

The 1.16.3 version introduced a github crash:


$ nhost sw version
Nhost CLI v1.16.3 for darwin-arm64
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/nhost/cli/cmd/software.commandVersion(0x14000880fc0)
        github.com/nhost/cli/cmd/software/version.go:32 +0x358
github.com/urfave/cli/v2.(*Command).Run(0x1400085cf20, 0x14000880fc0, {0x14000777200, 0x1, 0x1})
        github.com/urfave/cli/v2@v2.27.1/command.go:279 +0x71c
github.com/urfave/cli/v2.(*Command).Run(0x1400085d080, 0x14000880f00, {0x140007c78e0, 0x2, 0x2})
        github.com/urfave/cli/v2@v2.27.1/command.go:272 +0x918
github.com/urfave/cli/v2.(*Command).Run(0x1400085d4a0, 0x14000880c00, {0x140001aa2a0, 0x3, 0x3})
        github.com/urfave/cli/v2@v2.27.1/command.go:272 +0x918
github.com/urfave/cli/v2.(*App).RunContext(0x140006c5a00, {0x10235d170, 0x102f98de0}, {0x140001aa2a0, 0x3, 0x3})
        github.com/urfave/cli/v2@v2.27.1/app.go:337 +0x514
github.com/urfave/cli/v2.(*App).Run(...)
        github.com/urfave/cli/v2@v2.27.1/app.go:311
main.main()
        github.com/nhost/cli/main.go:58 +0xd54`
dbarrosop commented 7 months ago

thanks for reporting, will be fixed here: https://github.com/nhost/cli/pull/867