search

nhost / hasura-auth

Authentication for Hasura.
https://nhost.io
MIT License
376 stars 111 forks source link

fix(ci): update GitHub workflow to push to Docker Hub with git tag #432

Closed onehassan closed 9 months ago

onehassan commented 9 months ago

Checklist

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: 83c4f4ad69710d95558958c113da2ea359610333

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dbarrosop commented 9 months ago

will this also push to ECR?

onehassan commented 9 months ago

will this also push to ECR?

Yes it should be, the steps are there. I think it does but not using the correct version number. We will see upon the next release.