nhost / hasura-auth

Authentication for Hasura.
https://nhost.io
MIT License
376 stars 111 forks source link

fix: mount oauth and healthz routes correctly when specifying AUTH_API_PREFIX #433

Closed dbarrosop closed 9 months ago

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: 642e7a95ea4139b577320dfb5a0337ef36da494d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | hasura-auth | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dminkovsky commented 9 months ago

It appears that healthz is still broken after this. For example, when I run:

 docker run -p 4001:4000 --rm --network nhost-local_default -e "HASURA_GRAPHQL_ADMIN_SECRET=secret" -e "HASURA_GRAPHQL_DATABASE_URL=postgres://postgres:secret-pg-password-never-use-this-value@postgres:5432/postgres" -e "HASURA_GRAPHQL_GRAPHQL_URL=http://graphql-engine:8080/v1/graphql" -e "HASURA_GRAPHQL_JWT_SECRET=$HASURA_GRAPHQL_JWT_SECRET" nhost/hasura-auth:0.22.0
$ curl localhost:4001/version
{"version":"v0.22.0"}

but

$ curl localhost:4001/healthz
{"status":404,"message":"Route not found","error":"route-not-found"}
dbarrosop commented 9 months ago

See #440