search

nhost / hasura-auth

Authentication for Hasura.
https://nhost.io
MIT License
376 stars 111 forks source link

Custom schemes are not allowed to be used as redirectTo values #439

Closed spakanati closed 3 months ago

spakanati commented 9 months ago

It is possible to add "myapp://host" to allowed URLs but then when trying to use the custom scheme as a redirectTo, you get The+value+of+%22redirectTo%22+is+not+allowed.

I assume this is not expected behavior, since using custom schemes is the recommended way in the nhost-dart example to complete sign in with oauth providers.

I added an example failing test here.

I did a bit of digging and I think the failure happens here because valueUrl.origin is null for custom schemes.

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dbarrosop commented 3 months ago

Good timing to get a remind for this one... Will be fixed by https://github.com/nhost/hasura-auth/pull/513

dbarrosop commented 3 months ago

This should be supported now on 0.30.0.